Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(group): deprecate positional args in Group.{zeros,ones,etc.} #2416

Merged
merged 2 commits into from
Oct 20, 2024
Merged

fix(group): deprecate positional args in Group.{zeros,ones,etc.} #2416

merged 2 commits into from
Oct 20, 2024

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Oct 19, 2024 •
edited
Loading

Fixes #2402

Thanks @TomAugspurger for adding _deprecate_positional_args!

TODO:

  • Add unit tests and/or doctests in docstrings
  • GitHub Actions have all passed

@jhamman jhamman force-pushed the fix/dep-group-positional-args branch from f71cdc1 to 0eb4c8a Compare October 19, 2024 20:56
@jhamman jhamman merged commit 329612e into zarr-developers:main Oct 20, 2024
53 checks passed
@jhamman jhamman deleted the fix/dep-group-positional-args branch October 21, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v3] Group.{zeros, ones, etc.} should accept positional name arguments
2 participants
@jhamman @TomAugspurger